feat: add info section: server stats cpu commandstats

[hahahashen]

误删除了之前那个PR的分支，所以提了一个新的PR，原来PR comment可看 https://github.com/OpenAtomFoundation/pikiwidb/pull/326 ，都进行了回复与处理

Summary by CodeRabbit

• 新功能

  • 添加了新的统计和时间计算功能，可以跟踪命令统计信息和执行时间。
  • 提供了更详细的信息检索方法，包括服务器信息、统计信息、CPU 信息和数据库统计信息。
  • 引入了一个新的InfoSection枚举，支持不同信息区域的映射和处理。

• 改进

  • 更新了PClient类，增加了获取命令统计信息和时间统计的功能。
  • PikiwiDB类中添加了开始时间的初始化和检索方法。

• 修复

  • 改进了InfoCmd类的方法以处理不同类型的命令和信息。
  • 优化了DoCmd方法的逻辑，提供更详细的错误处理和信息格式。

• 重构

  • 对多个方法进行了重构，改进了性能并增强了代码的可读性和维护性。

[hahahashen]

运行截图如下所示

[AlexStocks]

@CodiumAI-Agent /review

[CodiumAI-Agent]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	4, because the PR introduces a significant amount of new functionality across multiple files, involving complex features like command statistics, time statistics, and server information retrieval. The changes are spread across multiple core components which requires a careful review to ensure compatibility and correctness.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: The `InfoCmd::DoInitial` method might set `info_section_` without checking if `argc` equals 2 before the check, which could lead to setting the response incorrectly if additional arguments are provided.
	Performance Concern: The method `InfoCmd::InfoCommandStats` iterates over all command statistics and performs calculations on them, which might be inefficient with a large number of commands.
🔒 Security concerns	No

Code feedback:

---

relevant file	src/cmd_thread_pool_worker.cc
suggestion	Consider using `emplace` directly with constructor arguments instead of creating a temporary `CommandStatistics` object. This avoids the overhead of default constructing an object and then copying over it. [important]
relevant line	cmdstat_map->emplace(task->CmdName(), statistics);

---

relevant file	src/cmd_admin.cc
suggestion	Instead of using multiple `if` statements to check `argv_[1].data()` against various sections, consider using a `std::map` or `std::unordered_map` to map section strings to `InfoSection` enums. This would make the code cleaner and more scalable if more sections are added in the future. [medium]
relevant line	} else if (strcasecmp(argv_[1].data(), kServerSection.data()) == 0) {

---

relevant file	src/cmd_admin.cc
suggestion	To avoid repeated code for appending "\r\n" in `InfoCmd::DoCmd`, consider creating a helper function that appends information followed by "\r\n". This will make the code cleaner and reduce the chance of missing the line break in future modifications. [medium]
relevant line	info.append("\r\n");

---

relevant file	src/client.cc
suggestion	Use `std::make_unique` instead of `new` for creating `time_stat_` to ensure exception safety and modern memory management practices. [important]
relevant line	time_stat_.reset(new TimeStat());

---

[AlexStocks]

@CodiumAI-Agent /improve

[CodiumAI-Agent]

PR Code Suggestions ✨

Category	Suggestion	Score
Performance	Use try_emplace to reduce map lookups ___ **Avoid using find followed by emplace which can lead to two lookups. Use try_emplace for a single lookup and insertion if not present.** [src/cmd_thread_pool_worker.cc [42-44]](https://github.com/OpenAtomFoundation/pikiwidb/pull/338/files#diff-24a4de80190fd7ed32279732bdadf550a2f7d5f3144f9dfe36ecc2e53d981f8aR42-R44) ```diff -if (cmdstat_map->find(task->CmdName()) == cmdstat_map->end()) { - cmdstat_map->emplace(task->CmdName(), statistics); -} +cmdstat_map->try_emplace(task->CmdName(), statistics); ``` Suggestion importance[1-10]: 10 Why: Using `try_emplace` reduces the number of lookups in the map, which improves performance. This suggestion is accurate and provides a clear performance benefit.	10
Best practice	Use member initializer lists in the copy constructor for efficiency and clarity ___ **The copy constructor for CommandStatistics should use member initializer lists for atomic types to ensure that the initialization is more efficient and the intent is clearer.** [src/client.h [25-27]](https://github.com/OpenAtomFoundation/pikiwidb/pull/338/files#diff-2ee628bb1cdcbf04f484b57ea20ddf172db2dfaeb22214ebfb24ff36718a7509R25-R27) ```diff -CommandStatistics(const CommandStatistics& other) { - cmd_time_consuming_.store(other.cmd_time_consuming_.load()); - cmd_count_.store(other.cmd_count_.load()); -} +CommandStatistics(const CommandStatistics& other) : cmd_count_(other.cmd_count_.load()), cmd_time_consuming_(other.cmd_time_consuming_.load()) {} ``` Suggestion importance[1-10]: 9 Why: Using member initializer lists in the copy constructor is a best practice that improves efficiency and clarity. This suggestion directly enhances the new code introduced in the PR.	9
	Initialize class members in the initializer list ___ **Consider initializing time_stat_ in the constructor initializer list instead of the constructor body for better performance and readability.** [src/client.cc [430]](https://github.com/OpenAtomFoundation/pikiwidb/pull/338/files#diff-4262ef19cc324c0e14881eee2b23dad25b6428d3e2ca1b27f1afcbb7bf5885ecR430-R430) ```diff -time_stat_.reset(new TimeTimeStat()); +PClient::PClient(TcpConnection* obj) : time_stat_(new TimeStat()), parser_(params_) { + auth_ = false; + reset(); +} ``` Suggestion importance[1-10]: 8 Why: Initializing class members in the initializer list is a best practice in C++ as it can improve performance and readability. This suggestion correctly identifies and addresses this issue.	8
	Add a self-assignment check in the copy constructor to prevent issues ___ **Consider checking for self-assignment in the copy constructor of CommandStatistics to prevent issues when an object is assigned to itself.** [src/client.h [25-27]](https://github.com/OpenAtomFoundation/pikiwidb/pull/338/files#diff-2ee628bb1cdcbf04f484b57ea20ddf172db2dfaeb22214ebfb24ff36718a7509R25-R27) ```diff CommandStatistics(const CommandStatistics& other) { - cmd_time_consuming_.store(other.cmd_time_consuming_.load()); - cmd_count_.store(other.cmd_count_.load()); + if (this != &other) { + cmd_time_consuming_.store(other.cmd_time_consuming_.load()); + cmd_count_.store(other.cmd_count_.load()); + } } ``` Suggestion importance[1-10]: 8 Why: Adding a self-assignment check is a good practice to prevent potential issues, although it is less critical than using member initializer lists. It is still a valuable improvement.	8
	Use std::chrono for better type safety and clarity in timestamp handling ___ **Use std::chrono for handling timestamps in TimeStat to make the time handling more type-safe and clear.** [src/client.h [41-43]](https://github.com/OpenAtomFoundation/pikiwidb/pull/338/files#diff-2ee628bb1cdcbf04f484b57ea20ddf172db2dfaeb22214ebfb24ff36718a7509R41-R43) ```diff -void SetEnqueueTs(uint64_t now_time) { enqueue_ts_ = now_time; } -void SetDequeueTs(uint64_t now_time) { dequeue_ts_ = now_time; } -void SetProcessDoneTs(uint64_t now_time) { process_done_ts_ = now_time; } +void SetEnqueueTs(std::chrono::milliseconds now_time) { enqueue_ts_ = now_time.count(); } +void SetDequeueTs(std::chrono::milliseconds now_time) { dequeue_ts_ = now_time.count(); } +void SetProcessDoneTs(std::chrono::milliseconds now_time) { process_done_ts_ = now_time.count(); } ``` Suggestion importance[1-10]: 6 Why: Using `std::chrono` for timestamp handling is a best practice that improves type safety and code clarity. However, it is a more stylistic improvement and less critical than the other suggestions.	6
Maintainability	Use a map for string comparison to simplify the logic ___ **Replace the manual string comparison with a case-insensitive map to simplify the command section checking logic and improve maintainability.** [src/client.cc [170-183]](https://github.com/OpenAtomFoundation/pikiwidb/pull/338/files#diff-4262ef19cc324c0e14881eee2b23dad25b6428d3e2ca1b27f1afcbb7bf5885ecR170-R183) ```diff -if (strcasecmp(argv_[1].data(), kAllSection.data()) == 0) { - info_section_ = kInfoAll; -} else if (strcasecmp(argv_[1].data(), kServerSection.data()) == 0) { - info_section_ = kInfoServer; -} else if (strcasecmp(argv_[1].data(), kStatsSection.data()) == 0) { - info_section_ = kInfoStats; -} else if (strcasecmp(argv_[1].data(), kCPUSection.data()) == 0) { - info_section_ = kInfoCPU; -} else if (strcasecmp(argv_[1].data(), kDataSection.data()) == 0) { - info_section_ = kInfoData; -} else if (strcasecmp(argv_[1].data(), kRaftSection.data()) == 0) { - info_section_ = kInfoRaft; -} else if (strcasecmp(argv_[1].data(), kCommandStatsSection.data()) == 0) { - info_section_ = kInfoCommandStats; +static const std::unordered_map section_map = { + {kAllSection, kInfoAll}, + {kServerSection, kInfoServer}, + {kStatsSection, kInfoStats}, + {kCPUSection, kInfoCPU}, + {kDataSection, kInfoData}, + {kRaftSection, kInfoRaft}, + {kCommandStatsSection, kInfoCommandStats} +}; +auto it = section_map.find(argv_[1]); +if (it != section_map.end()) { + info_section_ = it->second; } ``` Suggestion importance[1-10]: 9 Why: Using a map for string comparison simplifies the logic and improves maintainability. This suggestion is correct and provides a significant improvement in code readability and maintainability.	9
Possible bug	Improve the robustness of time calculations in TimeStat ___ **Replace the manual time calculations in TimeStat with a more robust time handling mechanism to avoid potential overflow or underflow errors.** [src/client.h [40]](https://github.com/OpenAtomFoundation/pikiwidb/pull/338/files#diff-2ee628bb1cdcbf04f484b57ea20ddf172db2dfaeb22214ebfb24ff36718a7509R40-R40) ```diff -uint64_t GetTotalTime() const { return process_done_ts_ > enqueue_ts_ ? process_done_ts_ - enqueue_ts_ : 0; } +uint64_t GetTotalTime() const { + if (process_done_ts_ > enqueue_ts_) { + return process_done_ts_ - enqueue_ts_; + } else { + // Handle potential underflow or unexpected timestamp values + return 0; + } +} ``` Suggestion importance[1-10]: 7 Why: This suggestion improves the robustness of the time calculation logic, which can prevent potential bugs related to overflow or underflow. It is a useful enhancement but not as crucial as the previous suggestions.	7

[coderabbitai[bot]]

Walkthrough

本次更改涉及多个文件，主要增强了命令统计和时间统计功能，改进了服务器信息的检索和显示。通过新增的结构体和方法，程序能够更有效地追踪命令执行的统计数据和时间消耗，从而提供更详尽的系统信息，提升了用户体验。

Changes

文件路径	变更摘要
src/client.cc, src/client.h	添加命令和时间统计功能，新增结构体和相关方法。
src/cmd_admin.cc, src/cmd_admin.h	InfoCmd 类增加多个方法，用于动态检索服务器、统计、CPU和命令统计信息。
src/cmd_table_manager.cc	在 GetCmdId 方法后添加一行空语句以改善代码结构。
src/pikiwidb.cc, src/pikiwidb.h	在 PikiwiDB::Init 方法中增加时间设置调用，并新增 Start_time_s 方法以返回启动时间。

🐇✨
代码变，功能增，
命令统计入心中。
时间消耗细追踪，
服务器信息更详尽。
兔子欢歌代码舞，
系统性能日日升。

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[AlexStocks]

请根据 CodeRabbitai 的改进意见，改进 PR

[Issues-translate-bot]

Bot detected the issue body's language is not English, translate it automatically.

---

Please improve the PR based on CodeRabbitai’s improvement suggestions

[hahahashen]

请根据 CodeRabbitai 的改进意见，改进 PR

好的 我稍晚点修改一下

[Issues-translate-bot]

Bot detected the issue body's language is not English, translate it automatically.

---

Please improve the PR based on CodeRabbitai’s improvement suggestions

Okay, I'll modify it later.

[dingxiaoshuai123]

@hahahashen 冲突了，请解决一下

[Issues-translate-bot]

Bot detected the issue body's language is not English, translate it automatically.

---

@hahahashen There is a conflict, please resolve it

[hahahashen]

@hahahashen 冲突了，请解决一下

done

[Issues-translate-bot]

Bot detected the issue body's language is not English, translate it automatically.

---

@hahahashen There is a conflict, please resolve it

done

[AlexStocks]

coderabbitai 留的几个 comment，我觉得还是比较合理的，还请根据 comment 意见继续改进。

[Issues-translate-bot]

Bot detected the issue body's language is not English, translate it automatically.

---

I think the comments left by coderabbitai are quite reasonable. Please continue to improve based on the comments.

[hahahashen]

coderabbitai 留的几个 comment，我觉得还是比较合理的，还请根据 comment 意见继续改进。

好的

[Issues-translate-bot]

Bot detected the issue body's language is not English, translate it automatically.

---

coderabbitai I think the few comments left are quite reasonable. Please continue to improve based on the comments.

OK

[hahahashen]

coderabbitai 留的几个 comment，我觉得还是比较合理的，还请根据 comment 意见继续改进。

done

[Issues-translate-bot]

Bot detected the issue body's language is not English, translate it automatically.

---

coderabbitai I think the few comments left are quite reasonable. Please continue to improve based on the comments.

done