feat: write to rocksdb by our Batch interface (hincrby hincrbyfloat hmset hsetnx)

longfar-ncy commented 1 month ago

issure: https://github.com/OpenAtomFoundation/pikiwidb/issues/280

Summary by CodeRabbit

测试
- 添加了一系列一致性测试，用于验证Redis命令（如HSetnx、HMSet、HIncrby、HIncrbyfloat、SAdd和SRem）的操作一致性和正确性。

coderabbitai[bot] commented 1 month ago

Walkthrough

这些变更主要涉及将 Redis 命令的操作从直接使用 rocksdb::WriteBatch 转换为使用封装的 Batch 接口。具体包括修改 HIncrby、HIncrbyfloat、HMSet 和 HSetnx 四个命令，以及为这些命令添加相应的一致性测试，以确保在批量操作时保持数据的一致性和正确性。

Changes

文件	修改摘要
src/storage/src/redis_hashes.cc	将 `rocksdb::WriteBatch` 替换为 `Batch::CreateBatch`。
tests/consistency_test.go	增加了 `HSetnx`、`HMSet`、`HIncrby` 和 `HIncrbyfloat` 的一致性测试；修改了 `SAdd & SRem` 的测试以包括一致性检查。

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant RedisServer
    participant Batch

    Client->>RedisServer: 请求 HIncrby/HIncrbyfloat/HMSet/HSetnx
    RedisServer->>Batch: 使用 Batch::CreateBatch 创建批处理
    Batch-->>RedisServer: 返回 Batch 对象
    RedisServer->>Batch: 执行 put 和 delete 操作
    RedisServer->>Batch: 调用 Batch 的 Commit 方法
    Batch-->>RedisServer: 返回 Commit 结果
    RedisServer-->>Client: 发送操作结果

Possibly related issues

OpenAtomFoundation/pikiwidb#280: 此问题建议将 RocksDB 的直接写操作替换为封装的 Batch 接口，解决方案与该 PR 一致。

Poem

在代码的海洋中寻梦，批处理接口现身跃鱼龙。增加测试守护一致性， Redis 栈中万变皆从容。 🐇🌟批代码，迎新风。

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

AlexStocks commented 1 month ago

CI 失败 fix 下

Issues-translate-bot commented 1 month ago

Bot detected the issue body's language is not English, translate it automatically.

CI failed fix next

OpenAtomFoundation / pikiwidb