OpenAtomFoundation / pikiwidb

a high-performance, large-capacity, multi-tenant, data-persistent, strong data consistency based on raft, Redis-compatible elastic KV data storage system based on RocksDB
BSD 3-Clause "New" or "Revised" License
195 stars 62 forks source link

feat: add cache layer & modify kv and list command with cache #434

Closed hahahashen closed 2 weeks ago

hahahashen commented 3 weeks ago

对pikiwidb添加cache层,主要有以下几个步骤: 1、引入rediscache依赖 2、封装rediscache接口 3、封装PCache类用以管理rediscache 4、封装PCacheLoadThread类用以cache miss时加载key到cache 5、将cache处理添加进原来的命令处理流程,以及DB初始化过程中(cache初始化成功与否不影响DB初始化) 6、新增cache配置项,并进行读取 7、命令改造,当前PR已经改造了 kv & list

coderabbitai[bot] commented 3 weeks ago

[!NOTE] Currently processing new changes in this PR. This may take a few minutes, please wait...

Commits Files that changed from the base of the PR and between b195f25d7195920403280fb27777798199a553bd and 37b58b85720bd631274831c2205d3a47ba46c03a.
Files selected for processing (31) * CMakeLists.txt (2 hunks) * cmake/jemalloc.cmake (1 hunks) * cmake/rediscache.cmake (1 hunks) * etc/conf/pikiwidb.conf (1 hunks) * src/CMakeLists.txt (3 hunks) * src/base_cmd.cc (1 hunks) * src/base_cmd.h (2 hunks) * src/cache/CMakeLists.txt (1 hunks) * src/cache/config.h (1 hunks) * src/cache/list.cc (1 hunks) * src/cache/redisCache.cc (1 hunks) * src/cache/redisCache.h (1 hunks) * src/cache/string.cc (1 hunks) * src/cache_define.h (1 hunks) * src/client.h (2 hunks) * src/cmd_keys.cc (8 hunks) * src/cmd_keys.h (10 hunks) * src/cmd_kv.cc (20 hunks) * src/cmd_kv.h (16 hunks) * src/cmd_list.cc (11 hunks) * src/cmd_list.h (13 hunks) * src/config.cc (2 hunks) * src/config.h (1 hunks) * src/db.cc (1 hunks) * src/db.h (3 hunks) * src/pcache.cc (1 hunks) * src/pcache.h (1 hunks) * src/pcache_load_thread.cc (1 hunks) * src/pcache_load_thread.h (1 hunks) * src/thread.cc (1 hunks) * src/thread.h (1 hunks)
 _____________________________________________________________________________
< Butterfly effect: one bug in your code can cause a hurricane in production. >
 -----------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

[!TIP]

Migrating from UI to YAML configuration. Use the `@coderabbitai configuration` command in a PR comment to get a dump of all your UI settings in YAML format. You can then edit this YAML file and upload it to the root of your repository to configure CodeRabbit programmatically.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.