search

OpenAtomFoundation / xupercore

The kernel of xuperchain.
Apache License 2.0
61 stars 47 forks source link

Fail fast when java runtime not found in java native contract #205

Closed chenfengjin closed 3 years ago

chenfengjin commented 3 years ago

using executable bin pathrather than sh to start docker container and host process to fail fast another benefit is that you can get more detail of native process starting failed for troubleshooting

codecov-commenter commented 3 years ago

Codecov Report

Merging #205 (6f92908) into master (b21e379) will increase coverage by 0.43%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   47.96%   48.39%   +0.43%     
==========================================
  Files         133      133              
  Lines       11341    11339       -2     
==========================================
+ Hits         5440     5488      +48     
+ Misses       4782     4722      -60     
- Partials     1119     1129      +10
Impacted Files Coverage Δ
bcs/contract/native/contract_process.go 68.90% <75.00%> (+10.08%) :arrow_up:
bcs/contract/native/runtime.go 69.23% <100.00%> (+56.32%) :arrow_up:
bcs/consensus/tdpos/common.go 64.06% <0.00%> (-3.13%) :arrow_down:
bcs/contract/xvm/code_manager.go 63.63% <0.00%> (-2.73%) :arrow_down:
bcs/consensus/tdpos/tdpos.go 43.04% <0.00%> (-2.18%) :arrow_down:
bcs/network/p2pv1/server.go 56.46% <0.00%> (-1.37%) :arrow_down:
kernel/consensus/base/driver/chained-bft/smr.go 52.41% <0.00%> (-0.97%) :arrow_down:
bcs/consensus/tdpos/schedule.go 48.40% <0.00%> (-0.92%) :arrow_down:
bcs/contract/native/process_manager.go 71.92% <0.00%> (+3.50%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b21e379...6f92908. Read the comment docs.