search

OpenAtomFoundation / xupercore

The kernel of xuperchain.
Apache License 2.0
61 stars 47 forks source link

returen detailed error info for quick troubleshooting when developing and operating #224

Closed chenfengjin closed 3 years ago

chenfengjin commented 3 years ago

Description

error return in golang is useful for troubleshooting when developing and operating. bad return value style like

return nil,nil

when the second value is an error type without any specific reason. it may take you hours even days to find a bug.

return an new error without context info like

if err!=nil{ return errors.New("new error") } also confuse you when you wanna find out what happend

codecov-commenter commented 3 years ago

Codecov Report

Merging #224 (e6939e9) into master (cd5e7dc) will decrease coverage by 0.16%. The diff coverage is 38.83%.

:exclamation: Current head e6939e9 differs from pull request most recent head 104688a. Consider uploading reports for the commit 104688a to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
- Coverage   47.51%   47.35%   -0.17%     
==========================================
  Files         133      133              
  Lines       11371    11370       -1     
==========================================
- Hits         5403     5384      -19     
- Misses       4848     4865      +17     
- Partials     1120     1121       +1
Impacted Files Coverage Δ
bcs/contract/evm/abi/abi.go 44.00% <0.00%> (ø)
bcs/contract/evm/address.go 86.58% <0.00%> (ø)
bcs/contract/evm/creator.go 27.36% <0.00%> (ø)
bcs/contract/xvm/builtin_resolver.go 0.00% <0.00%> (ø)
bcs/ledger/xledger/state/block.go 0.00% <0.00%> (ø)
bcs/ledger/xledger/state/utxo/utxo.go 55.18% <0.00%> (ø)
bcs/network/p2pv1/server.go 57.82% <0.00%> (ø)
kernel/network/p2p/subscriber.go 43.93% <ø> (ø)
lib/storage/kvdb/leveldb/ldb_impl.go 1.35% <0.00%> (+0.01%) :arrow_up:
bcs/network/p2pv1/client.go 49.12% <8.33%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cd5e7dc...104688a. Read the comment docs.