OpenAtomFoundation / xupercore

The kernel of xuperchain.
Apache License 2.0
61 stars 47 forks source link

fix bug: get unconfirm txs from mempool maybe ignore block size limit. #276

Closed godeamon closed 2 years ago

godeamon commented 2 years ago

根据区块大小会从 mempool 中打包区块,可能导致将 mempool 中交易全部打包,算法问题。

codecov-commenter commented 2 years ago

Codecov Report

Merging #276 (0ec05cc) into master (afc1962) will increase coverage by 0.01%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage   46.54%   46.56%   +0.01%     
==========================================
  Files         136      136              
  Lines       12095    12097       +2     
==========================================
+ Hits         5630     5633       +3     
+ Misses       5301     5297       -4     
- Partials     1164     1167       +3     
Impacted Files Coverage Δ
bcs/ledger/xledger/tx/tx.go 39.87% <33.33%> (+0.77%) :arrow_up:
bcs/contract/xvm/code_manager.go 63.63% <0.00%> (-2.73%) :arrow_down:
bcs/consensus/xpoa/xpoa.go 53.76% <0.00%> (-2.16%) :arrow_down:
kernel/consensus/base/driver/chained-bft/smr.go 42.13% <0.00%> (-0.80%) :arrow_down:
bcs/network/p2pv2/server.go 52.40% <0.00%> (+1.06%) :arrow_up:
bcs/consensus/pow/pow.go 42.96% <0.00%> (+3.42%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update afc1962...0ec05cc. Read the comment docs.