OpenAtomFoundation / xupercore

The kernel of xuperchain.
Apache License 2.0
61 stars 47 forks source link

问题:poa和pos类共识配置如果init_proposer参数为空会导致panic或者节点无法出块的错误 #301

Closed wangchao0222 closed 2 years ago

wangchao0222 commented 2 years ago

Description

问题:poa和pos类共识配置如果init_proposer参数为空会导致panic或者节点无法出块的错误

Fixes # (issue)

解决:poa和pos类共识实例创建的时候增加init_proposer参数校验,校验失败返回错误

Type of change

Please delete options that are not relevant.

Brief of your solution

poa和pos类共识实例创建的时候增加init_proposer参数校验,校验失败返回错误

How Has This Been Tested?

升级到poa和pos类共识时desc文件内部缺少init_proposer参数会导致共识升级失败 错误日志标签:

  1. 升级到tdpos:init_proposer is required 或者 init_proposer["1"] is required
  2. 升级到poa:init_proposer.address is required
codecov-commenter commented 2 years ago

Codecov Report

Merging #301 (ad5b3da) into master (4956854) will decrease coverage by 0.03%. The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
- Coverage   46.52%   46.48%   -0.04%     
==========================================
  Files         136      136              
  Lines       12191    12199       +8     
==========================================
- Hits         5672     5671       -1     
- Misses       5348     5355       +7     
- Partials     1171     1173       +2     
Impacted Files Coverage Δ
bcs/consensus/xpoa/xpoa.go 55.44% <0.00%> (-0.88%) :arrow_down:
bcs/consensus/tdpos/common.go 55.07% <20.00%> (-2.75%) :arrow_down:
bcs/network/p2pv2/server.go 51.33% <0.00%> (-1.07%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4956854...ad5b3da. Read the comment docs.