Default API and MongoDB endpoints to localhost

OpenAttackDefenseTools / tulip

Network analysis tool for Attack Defence CTF

GNU General Public License v3.0

264 stars 36 forks source link

Default API and MongoDB endpoints to localhost #2

Closed erdnaxe closed 2 years ago

erdnaxe commented 2 years ago

First of all, thank you for sharing this awesome code!

This pull request proposes to default all API and MongoDB endpoints to localhost when the respective environment variable is absent. This seems to be a sanier default than hardcoding containers hostname in the code. It also renames REACT_APP_FLAG_REGEX to FLAG_REGEX, which might have been a bug.

Best regards,

erdnaxe commented 2 years ago

RickdeJager commented 2 years ago

Thanks!