search

OpenBAS-Platform / openbas

Open Breach and Attack Simulation Platform
https://openbas.io
Other
213 stars 23 forks source link

[backend/frontend] Fix import #1069

Closed RomuDeuxfois closed 1 month ago

RomuDeuxfois commented 1 month ago

Related issues

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 44.55446% with 112 lines in your changes missing coverage. Please review.

Project coverage is 26.67%. Comparing base (3366c8a) to head (e7660a4). Report is 3 commits behind head on master.

Files Patch % Lines
...main/java/io/openbas/importer/V1_DataImporter.java 50.60% 69 Missing and 12 partials :warning:
...as/rest/exercise/exports/ExerciseExportMixins.java 0.00% 16 Missing :warning:
...rc/main/java/io/openbas/rest/inject/InjectApi.java 11.11% 8 Missing :warning:
...ain/java/io/openbas/rest/exercise/ExerciseApi.java 0.00% 5 Missing :warning:
...s/migration/V3_16__Add_array_union_agg_method.java 75.00% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1069 +/- ## ============================================ + Coverage 25.60% 26.67% +1.06% - Complexity 1014 1046 +32 ============================================ Files 464 464 Lines 10877 10996 +119 Branches 532 562 +30 ============================================ + Hits 2785 2933 +148 + Misses 8026 7978 -48 - Partials 66 85 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Dimfacion commented 1 month ago

Probleme de Prod_2024-06-13T14_3202.159342300Z(with_teams & with_players & with_variable_values).zip As seen together, I've had NPE with this import zip

RomuDeuxfois commented 1 month ago

Probleme de Prod_2024-06-13T14_3202.159342300Z(with_teams & with_players & with_variable_values).zip As seen together, I've had NPE with this import zip

It's fixed, and it revealed another bug. We no longer link the documents to the exercise when creating an inject in an exercise.