OpenBAS-Platform / openbas

Open Breach and Attack Simulation Platform
https://openbas.io
Other
492 stars 46 forks source link

[backend] Fixing random login errors #1085

Closed Dimfacion closed 3 months ago

Dimfacion commented 3 months ago

Proposed changes

Related issues

Checklist

Further comments

This needs to be tested extensively ... The fix is to prevent the callback of the SAML Provider to recreate an HttpSession if the previous one is older than 120s.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 16.66667% with 25 lines in your changes missing coverage. Please review.

Project coverage is 27.03%. Comparing base (ae5f5ce) to head (9802c54). Report is 15 commits behind head on master.

Files Patch % Lines
...g/OpenBASSaml2AuthenticationRequestRepository.java 16.66% 25 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1085 +/- ## ============================================ - Coverage 27.06% 27.03% -0.03% - Complexity 1056 1058 +2 ============================================ Files 468 469 +1 Lines 11059 11089 +30 Branches 558 561 +3 ============================================ + Hits 2993 2998 +5 - Misses 7981 8006 +25 Partials 85 85 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.