OpenBAS-Platform / openbas

Open Breach and Attack Simulation Platform
https://openbas.io
Other
488 stars 46 forks source link

After deleting a payload, atomic testing is throwing an error when accessing #1141

Closed SamuelHassine closed 2 months ago

SamuelHassine commented 3 months ago

Description

image

Click on one of the list that is noted "deleted".

jborozco commented 3 months ago

The error message should say: "This payload has been deleted."

savacano28 commented 3 months ago

@jborozco I fixed the crash, but I have some questions... when a payload is deleted, what happens in the following scenarios :

Image

Image

Image

Image

Image

SamuelHassine commented 3 months ago

I don't know how this fix has passed the review @RomuDeuxfois @Dimfacion.

First test: going to an atomic testing with a deleted payload, then clicking on configure:

image

Drawer is empty. Button should be disabled, and the screen should reflect the fact that the payload is not present anymore and this atomic testing cannot be replayed again. To be refined with @jborozco .

savacano28 commented 3 months ago

@SamuelHassine @jborozco Sure, I pointed out the concerns initially, but the main issue was a crashing page. I thought fixing that was priority number one, and these enhancements could be another ticket also?

Dimfacion commented 3 months ago

@SamuelHassine, Like @savacano28 pointed out, she told me about the issue. We thought it was more urgent to fix something crashing even if it meant having a temporary degraded version of the page. Sorry for not communicating enough on this call. Please, reach out if you feel we should handle the issue differently in the future.

RomuDeuxfois commented 2 months ago

When a payload is deleted then the contract is deleted.

Results:

RomuDeuxfois commented 2 months ago

Exporting a scenario or a simulation with a deleted inject, then importing it -> INTERNAL ERROR