OpenBAS-Platform / openbas

Open Breach and Attack Simulation Platform
https://openbas.io
Other
488 stars 46 forks source link

[backend] Add dynamic assets as children in group asset if applicable (#1055) #1154

Closed savacano28 closed 3 months ago

savacano28 commented 3 months ago

Proposed changes

Related issues

Checklist

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 26.11%. Comparing base (4f0629a) to head (19ef8b2).

Files Patch % Lines
...main/java/io/openbas/utils/AtomicTestingUtils.java 0.00% 21 Missing :warning:
.../java/io/openbas/service/AtomicTestingService.java 0.00% 4 Missing :warning:
.../openbas/rest/atomic_testing/AtomicTestingApi.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1154 +/- ## ============================================ + Coverage 25.88% 26.11% +0.23% - Complexity 1077 1081 +4 ============================================ Files 485 485 Lines 11796 11814 +18 Branches 635 638 +3 ============================================ + Hits 3053 3085 +32 + Misses 8653 8639 -14 Partials 90 90 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Dimfacion commented 3 months ago

I think your code do fix the alignment issue but they do not appear selected when selecting them.

savacano28 commented 3 months ago

Fixed: image image