[backend/frontend] Fix editing challenge

RomuDeuxfois commented 4 days ago

Closes https://github.com/OpenBAS-Platform/openbas/issues/1758

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 33.30%. Comparing base (d20c8e3) to head (7324127). Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
...io/openbas/rest/challenge/form/ChallengeInput.java	0.00%	8 Missing :warning:
...n/java/io/openbas/rest/challenge/ChallengeApi.java	0.00%	6 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1886 +/- ## ============================================ + Coverage 33.04% 33.30% +0.26% - Complexity 1653 1676 +23 ============================================ Files 571 571 Lines 16766 16764 -2 Branches 971 974 +3 ============================================ + Hits 5540 5584 +44 + Misses 10979 10933 -46 Partials 247 247 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

isselparra commented 3 days ago

TEST OK

Creation of Challenge -> OK, No regression
Update of a Challenge -> OK, fix works

I have a question regarding the values of Score and Max number of attempts, is it normal that I'm able to set negative numbers? I updated my Challenge with a -0.43 Score and a -42 as Max number of attempts Screenshot from 2024-11-19 16-14-38

RomuDeuxfois commented 3 days ago

TEST OK

Creation of Challenge -> OK, No regression

Update of a Challenge -> OK, fix works

I have a question regarding the values of Score and Max number of attempts, is it normal that I'm able to set negative numbers? I updated my Challenge with a -0.43 Score and a -42 as Max number of attempts

Taking care of it

Ready for a second round

isselparra commented 3 days ago

TEST OK

Creation of Challenge -> OK, No regression
Update of a Challenge -> OK, fix works

Just a last question, to be sure, a Score can only be an integer ? In the DB it's indicated as double precision

OpenBAS-Platform / openbas

[backend/frontend] Fix editing challenge #1886

Codecov Report