search

OpenBB-finance / OpenBB

Investment Research for Everyone, Everywhere.
https://openbb.co
Other
34.01k stars 3.11k forks source link

[Bug] Unable to load crypto coin even though it is found via `find` #1703

Closed MLNW closed 2 years ago

MLNW commented 2 years ago

Describe the bug

For some coins (at least one) the terminal finds the correct one but is unable to load it. The error on load is as follows: Could not find coin with given id.

To Reproduce

Here is a routine that reproduces the issue:

crypto
find lucky-block
load lucky-block
load lblock

Output on my machine:

❯ python terminal.py routines/bug_example.openbb
2022 Apr 14, 23:05 (🦋) /crypto/ $ find lucky-block
                Similar Coins
┏━━━━━━━┳━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓
┃ index ┃ symbol ┃ id          ┃ name        ┃
┡━━━━━━━╇━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩
│ 0     │ lblock │ lucky-block │ Lucky Block │
├───────┼────────┼─────────────┼─────────────┤
│ 1     │ lucky  │ lucky-2     │ LUCKY       │
├───────┼────────┼─────────────┼─────────────┤
│ 1     │ lucky  │ lucky-cat   │ Lucky Cat   │
├───────┼────────┼─────────────┼─────────────┤
│ 1     │ lucky  │ lucky-lion  │ Lucky Lion  │
├───────┼────────┼─────────────┼─────────────┤
│ 1     │ lucky  │ lucky-token │ Lucky Token │
├───────┼────────┼─────────────┼─────────────┤
│ 2     │ lucky  │ lucky-2     │ LUCKY       │
├───────┼────────┼─────────────┼─────────────┤
│ 2     │ lucky  │ lucky-cat   │ Lucky Cat   │
├───────┼────────┼─────────────┼─────────────┤
│ 2     │ lucky  │ lucky-lion  │ Lucky Lion  │
├───────┼────────┼─────────────┼─────────────┤
│ 2     │ lucky  │ lucky-token │ Lucky Token │
├───────┼────────┼─────────────┼─────────────┤
│ 3     │ lucky  │ lucky-2     │ LUCKY       │
├───────┼────────┼─────────────┼─────────────┤
│ 3     │ lucky  │ lucky-cat   │ Lucky Cat   │
├───────┼────────┼─────────────┼─────────────┤
│ 3     │ lucky  │ lucky-lion  │ Lucky Lion  │
├───────┼────────┼─────────────┼─────────────┤
│ 3     │ lucky  │ lucky-token │ Lucky Token │
├───────┼────────┼─────────────┼─────────────┤
│ 4     │ lucky  │ lucky-2     │ LUCKY       │
├───────┼────────┼─────────────┼─────────────┤
│ 4     │ lucky  │ lucky-cat   │ Lucky Cat   │
├───────┼────────┼─────────────┼─────────────┤
│ 4     │ lucky  │ lucky-lion  │ Lucky Lion  │
├───────┼────────┼─────────────┼─────────────┤
│ 4     │ lucky  │ lucky-token │ Lucky Token │
├───────┼────────┼─────────────┼─────────────┤
│ 5     │ block  │ blockasset  │ Blockasset  │
├───────┼────────┼─────────────┼─────────────┤
│ 5     │ block  │ blocknet    │ Blocknet    │
├───────┼────────┼─────────────┼─────────────┤
│ 6     │ block  │ blockasset  │ Blockasset  │
├───────┼────────┼─────────────┼─────────────┤
│ 6     │ block  │ blocknet    │ Blocknet    │
└───────┴────────┴─────────────┴─────────────┘

            Similar Coins
┏━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓
┃ index ┃ id          ┃ name        ┃
┡━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩
│ 0     │ lucky-block │ Lucky Block │
├───────┼─────────────┼─────
────────┤
│ 1     │ lucky-lion  │ Lucky Lion  │
└───────┴─────────────┴─────────────┘
2022 Apr 14, 23:05 (🦋) /crypto/ $ load lucky-block
Could not find coin with given id: lucky-block

2022 Apr 14, 23:05 (🦋) /crypto/ $ load lblock
Error: 'lblock'

Desktop (please complete the following information):

minhhoang1023 commented 2 years ago

We will be revamp the crypto load function next sprint, and this will be resolved

MLNW commented 2 years ago

I think this has been resolved:

❯ python terminal.py routines/bug_example.openbb 
2022 Apr 30, 16:55 (🦋) /crypto/ $ find lucky-block
                  Similar Coins
┏━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓
┃ index ┃ symbol    ┃ id          ┃ name        ┃
┡━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩
│ 0     │ lblock    │ lucky-block │ Lucky Block │
├───────┼───────────┼─────────────┼─────────────┤
│ 1     │ lucky     │ lucky-2     │ LUCKY       │
├───────┼───────────┼─────────────┼─────────────┤
│ 1     │ lucky     │ lucky-cat   │ Lucky Cat   │
├───────┼───────────┼─────────────┼─────────────┤
│ 1     │ lucky     │ lucky-lion  │ Lucky Lion  │
├───────┼───────────┼─────────────┼─────────────┤
│ 2     │ lucky     │ lucky-2     │ LUCKY       │
├───────┼───────────┼─────────────┼─────────────┤
│ 2     │ lucky     │ lucky-cat   │ Lucky Cat   │
├───────┼───────────┼─────────────┼─────────────┤
│ 2     │ lucky     │ lucky-lion  │ Lucky Lion  │
├───────┼───────────┼─────────────┼─────────────┤
│ 3     │ lucky     │ lucky-2     │ LUCKY       │
├───────┼───────────┼─────────────┼─────────────┤
│ 3     │ lucky     │ lucky-cat   │ Lucky Cat   │
├───────┼───────────┼─────────────┼─────────────┤
│ 3     │ lucky     │ lucky-lion  │ Lucky Lion  │
├───────┼───────────┼─────────────┼─────────────┤
│ 4     │ block     │ blockasset  │ Blockasset  │
├───────┼───────────┼─────────────┼─────────────┤
│ 4     │ block     │ blocknet    │ Blocknet    │
├───────┼───────────┼─────────────┼─────────────┤
│ 5     │ block     │ blockasset  │ Blockasset  │
├───────┼───────────┼─────────────┼─────────────┤
│ 5     │ block     │ blocknet    │ Blocknet    │
├───────┼───────────┼─────────────┼─────────────┤
│ 6     │ luckydoge │ luckydoge   │ LuckyDoge   │
└───────┴───────────┴─────────────┴─────────────┘

            Similar Coins
┏━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓
┃ index ┃ id          ┃ name        ┃
┡━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩
│ 0     │ lucky-block │ Lucky Block │
├───────┼─────────────┼─────────────┤
│ 1     │ lucky-lion  │ Lucky Lion  │
└───────┴─────────────┴─────────────┘
2022 Apr 30, 16:55 (🦋) /crypto/ $ load lucky-block

Could not find lucky-block in CoinPaprika. Make sure you search for symbol (e.g., btc) or try another source

2022 Apr 30, 16:55 (🦋) /crypto/ $ load lblock

Could not find lblock in CoinPaprika. Make sure you search for symbol (e.g., btc) or try another source

2022 Apr 30, 16:55 (🦋) /crypto/ $ load --source cg -c lblock

Loaded lucky-block against usd from CoinGecko source

Current Price: 0.0 USD
Performance in interval (1day): -12.72%
Performance since 2021-04-29: 74.39%