OpenBB-finance / OpenBBTerminal

Investment Research for Everyone, Everywhere.
https://openbb.co
Other
26.6k stars 2.6k forks source link

[Bug] /funds/load returns 403 error. #2724

Closed chrismolli closed 1 year ago

chrismolli commented 1 year ago

Describe the bug Upon loading of a fund by name or symbol the terminal returns:

openbb_terminal.mutual_funds.investpy_model|get_fund_historical|0|Exception: ERR#0015: error 403, try again later. 
- Traceback (most recent call last): 
- File cut/file/path/decorators.py, line 66, in wrapper - value = func(*args, **kwargs) 
- File cut/file/path/investpy_model.py, line 189, in get_fund_historical 
- investpy.funds.get_fund_historical_data( 
- File cut/file/path/funds.py, line 638, in get_fund_historical_data
- ConnectionError: ERR#0015: error 403, try again later.

To Reproduce Open the terminal, go to funds, load a fund symbol.

Screenshots

Desktop (please complete the following information):

Additional context According to the underlying usage of investpy the function get_fund_historical_data is broken due to an undocumented API deprecation by Investing.com. The analogue issue for stocks is tracked here.

jmaslek commented 1 year ago

As you mention, we are hoping that this gets patched up. We can look into commenting out the function for the time being.

An interim fix could be to load through the stocks menu. For example, if I run funds/overview, I see FCNTX on there, which I can load using stocks/load FCNTX. If you are looking outside the US, I am not sure if things will match up between yahoo's naming and investing.coms naming.

deeleeramone commented 1 year ago

this error message is different, and is a recent development:

Screen Shot 2022-10-06 at 9 51 01 PM
alvarobartt commented 1 year ago

Hi, @jmaslek note that I released investiny just a week ago and it supports more or less the same functionality as investpy, while I wait for Investing.com to answer my email to get to an agreement to continue developing investpy.

If you need help with the integration of investiny in your package let me know and I'll try to fill in a PR 🤗 All the best!

chrismolli commented 1 year ago

this error message is different, and is a recent development:

Screen Shot 2022-10-06 at 9 51 01 PM

This is just what is printed in the frontend. When you look at your logs under ~/OpenBBUserData/logs/ you will see the underlying log messages.

jmaslek commented 1 year ago

Hi, @jmaslek note that I released investiny just a week ago and it supports more or less the same functionality as investpy, while I wait for Investing.com to answer my email to get to an agreement to continue developing investpy.

If you need help with the integration of investiny in your package let me know and I'll try to fill in a PR 🤗 All the best!

Hi @alvarobartt! Nice to chat with you :)

I did dig around slightly with the new package and was going to look into using that once you have the time stamps integrated (ummmm looks like you have added that now!). Currently I have only integrated your package with mutual fund menus but will be looking at adding more in the upcoming months.

If there are more areas you would like to integrate, we can chat :)

alvarobartt commented 1 year ago

Hi, @jmaslek note that I released investiny just a week ago and it supports more or less the same functionality as investpy, while I wait for Investing.com to answer my email to get to an agreement to continue developing investpy.

If you need help with the integration of investiny in your package let me know and I'll try to fill in a PR 🤗 All the best!

Hi @alvarobartt! Nice to chat with you :)

I did dig around slightly with the new package and was going to look into using that once you have the time stamps integrated (ummmm looks like you have added that now!). Currently I have only integrated your package with mutual fund menus but will be looking at adding more in the upcoming months.

If there are more areas you would like to integrate, we can chat :)

I'm still working on some fixes, improvements and new features, but sure we can have a chat to collaborate on both ends. Keep up the great work! ✨