search

OpenBCI / OpenBCI_Cyton_Library

Repository for OpenBCI Cyton Arduino Libraries
MIT License
87 stars 88 forks source link

Feature/Useful LED and testing markers #80

Closed gerrievanzyl closed 6 years ago

gerrievanzyl commented 6 years ago

The purpose of these change are two fold: 1) to implement useful LED signals ( LED goes off for 500ms when maker is received) 2) LED signals active SD card writing ((50ms:ON, 50ms:OFF) 3) LED can be switched on or off as before

Then I have made some changes to force the board into marker mode for testing

Please do not accept this request yet, let me test it first. This is just and FYIO

gerrievanzyl commented 6 years ago

AJ,

Please consider this pull request. Mostly benign, just adds some useful flashing to the LED to signal: 1) markers 2) SD write activity

I have cleaned all the testing junk

gerrievanzyl commented 6 years ago

@aj-ptw I put a block around the led writing in debug mode. I am not entirely familiar with the DEBUG states (there are two I see) so you should check this.

Here it is https://github.com/gerrievanzyl/OpenBCI_32bit_Library/blob/233575bf7c36ce3ac85e9d95060c8cee4567e725/OpenBCI_32bit_Library.cpp#L1738-L1766

agharibans commented 6 years ago

I would absolutely love the flashing LED with SD write activity! How close is it to being implemented?

gerrievanzyl commented 6 years ago

Sorry for the delays in responding. I was in a remote village in South Africa, and got back yesterday.

The flashing SD write is already implemented. Download the latest master branch of this.

https://github.com/OpenBCI/OpenBCI_32bit_Library

Gerrie

On Tue, Jan 2, 2018 at 7:27 PM, Armen Gharibans notifications@github.com wrote:

I would absolutely love the flashing LED with SD write activity! How close is it to being implemented?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OpenBCI/OpenBCI_32bit_Library/pull/80#issuecomment-354822369, or mute the thread https://github.com/notifications/unsubscribe-auth/AOSh_8qitVHX5Gdq4YXsAltTpQpTYWN-ks5tGmcWgaJpZM4QNTTz .