Reconfigure lead-off detection every ADS reset

OpenBCI / OpenBCI_Cyton_Library

Repository for OpenBCI Cyton Arduino Libraries

MIT License

87 stars 88 forks source link

Reconfigure lead-off detection every ADS reset #95

Open bmartin427 opened 4 years ago

bmartin427 commented 4 years ago

Previously, this was only done at initial board reset, but this state would get clobbered any time the sample rate was changed.

Also, this commit bumps the firmware version to 3.1.3.

Addresses #94.

wjcroft commented 4 years ago

Brad, this sounds great. Thanks very much for sleuthing this out. Mentioning @retiutut @conorrussomanno @produceconsumerobot @shirleyzhang867

wjcroft commented 4 years ago

Also mentioning @andrewjaykeller . AJ, this fixes impedance reading using the Wifi Shield, which was previously broken because of missing ADS1299 lead off setting.

wjcroft commented 4 years ago

Conor @conorrussomanno, who will merge this Pull Request? AJ likes it, but I don't think he has write access. There is another PR from May regarding reseting an SD card flag. Looks benign.

Seems like the firmware version number bump that Brad included in his PR is also a good idea.