OpenBCI / OpenBCI_GUI

A cross platform application for the OpenBCI Cyton and Ganglion. Tested on Mac, Windows and Ubuntu/Mint Linux.
MIT License
709 stars 259 forks source link

Refactor the creation and playback of OpenBCI GUI data files #1120

Closed retiutut closed 1 year ago

retiutut commented 1 year ago
retiutut commented 1 year ago

Still TODO:

retiutut commented 1 year ago

Tested with:

retiutut commented 1 year ago

In W_Playback the MenuList object does not perform well upon resizing. This should be replaced by an array of buttons or some other solution. All other calls to this UI object are not resized, as they are in the Control Panel.

retiutut commented 1 year ago

Sending to NYC office for final testing as performed here: https://github.com/OpenBCI/OpenBCI_GUI/pull/1120#issuecomment-1536686587

retiutut commented 1 year ago

Playback mode is working great on my end. I tested all the board configurations you mentioned. A few notes:

  • The first time I click “Select OpenBCI playback file” after launching the GUI, the open file explorer window opens behind my other windows (Windows 10). Only happens the first time I click the button.
  • Error when trying to record a 16 channel synthetic stream. Don’t get this problem when testing GUI 5.1.0 image
  • Maybe add name of selected file below “Select OpenBCI playback file”. Not necessary but it confused me at first if I had selected a file

Great catch! I'll fix this here in this PR. The session settings for both playback and synthetic sessions were misnamed.

We do say in the status bar at the bottom of the GUI that the file was selected. Also appears in the console log. We do this in the status bar since there is enough space to display longer file names.

Screen Shot 2023-05-09 at 4 42 35 PM

retiutut commented 1 year ago

Ok @isaacplotkin, the fix for synthetic mode not launching is in.

isaacplotkin commented 1 year ago

Great, synthetic mode fix is working for me.