Closed retiutut closed 1 year ago
@mhrahmani you are welcome to review and test also!
ICYMI I did a test: https://github.com/OpenBCI/OpenBCI_GUI/issues/1042#issuecomment-1592220997
Mainly the Time Series crashes, and FFT has addressing conflicts. The rest works well.
Checklist from #971
[x] Remove unnecessary code
[x] Reconfirm all data outputs for all data modes or improve as needed
[x] LSL - Look at all instances of push_sample and push_chunk to see what is correct and proper, and make changes so that this networking mode is refined and can operate as the "most-used" protocol.
Double check networking output guide.... mention that data may be sent in "chunks"for LSL and maybe other data modes. (e.g. [[sample1 s1 s1 s1],[sample2 s2 s2 s2],[sample3 etc.]] ) https://github.com/OpenBCI/Documentation/issues/170
[x] Confirm and review Serial
[x] Confirm and review UDP
[x] Confirm and review OSC
[x] Confirm and review LSL