search

OpenBCI / OpenBCI_GUI

A cross platform application for the OpenBCI Cyton and Ganglion. Tested on Mac, Windows and Ubuntu/Mint Linux.
MIT License
723 stars 260 forks source link

Rename UDP type field of EMG Joystick #1184

Closed isaacplotkin closed 1 year ago

isaacplotkin commented 1 year ago

Problem

Christian brought up a good point that the type field in the UDP packet for the EMG joystick is named "DroneControl", but it would more sense to have a more generic name since the EMG joystick can be used to control more than just a drone.

Expected

Rename this UDP packet type to "Joystick" or "EMGJoystick"

GUI Version

v5.2.1

retiutut commented 1 year ago

In this version of the GUI, it is already like this.

} else if (this.protocol.equals("UDP")) {
            StringBuilder output = new StringBuilder("{\"type\":\"emgJoystick\",\"data\":[");