Add EV certificate signing for Windows builds

OpenBCI / OpenBCI_GUI

A cross platform application for the OpenBCI Cyton and Ganglion. Tested on Mac, Windows and Ubuntu/Mint Linux.

MIT License

708 stars 257 forks source link

Add EV certificate signing for Windows builds #1186

Closed philippitts closed 1 year ago

philippitts commented 1 year ago

Replaces code signing for Windows builds with Extended Validation code signing which provides additional guarantees to end-user systems and reduces warning about untrusted software
Extracts code signing along with other OS specific logic from the make_release.py script
Decomposes the make_release.py script into a build.py and package.py script

retiutut commented 1 year ago

Looking great so far. Did an early review.

philippitts commented 1 year ago

@retiutut can you double check that the BrainFlow library setup for MacOS is still correct? I ran builds on Windows and MacOS and they seem correct, but it would be great to have you confirm it.

philippitts commented 1 year ago

The v5 GUI used to store build artifacts with timestamps in the names, but we've taken those out for v6. If you prefer to have timestamps in the name we can just drop the related commit and it should work. However, I think we can use versioning for the artifacts in AWS and it will work better.

philippitts commented 1 year ago

Updated the PR based on your feedback and tested on Windows, MacOS, and Linux. Things are working as expected and it's ready for another review pass.