OpenBCI / OpenBCI_GUI

A cross platform application for the OpenBCI Cyton and Ganglion. Tested on Mac, Windows and Ubuntu/Mint Linux.
MIT License
704 stars 255 forks source link

Feature: Cyton Impedance Check Headplot #648

Open retiutut opened 4 years ago

retiutut commented 4 years ago

Is your feature request related to a problem? Please describe. Takes too long to check impedance on all channels when using Cyton and Cyton+Daisy.

Describe the solution you'd like A way to test impedance on all Cyton channels at once, and possibly display this on a headplot diagram.

Describe alternatives you've considered Current solution requires users to click all 16buttons on and off. Could also implement an Expert Mode keyboard shortcut.

Additional context https://openbci.com/forum/index.php?p=/discussion/2364/feature-request-impedance-check-map#latest

f1hiqcU

markopetrovic-neurotech commented 3 years ago

Cant this be done simply by swapping the eeg data used in Headplot with the global impedence data variable?

headPlot.setIntensityData_byRef(dataProcessing.data_std_uV, is_railed); -> headPlot.setIntensityData_byRef(data_elec_imp_ohm, is_railed);

retiutut commented 3 years ago

@markopetrovic-neurotech It's technically correct but not so simple. Thanks for mentioning this here on the thread though!

If you look at the image above, the issue arises when users choose something other than the default electrode positions. We need to expand the electrode map to something like what's shown above and make it configurable/assignable to channels. This requires some careful UI/UX work that I have been discussing with the OpenBCI team at meetings and contemplating for some time.

963

markopetrovic-neurotech commented 3 years ago

@retiutut Thanks for the timely responses!

I thought we could load other electrode positions from electrode_position.txt files, or is the issue for mappings with more than 16 electrodes?

Also I see the position electrode_xy array is being updated when the electrodes are dragged, it seems to be working but I'm not sure if I can tell the difference.

Thanks again, I'm excited for the upcoming milestone and would love to help where I can.

retiutut commented 3 years ago

Thanks for the timely responses!

I thought we could load other electrode positions from electrode_position.txt files, or is the issue for mappings with more than 16 electrodes?

Also I see the position electrode_xy array is being updated when the electrodes are dragged, it seems to be working but I'm not sure if I can tell the difference.

Thanks again, I'm excited for the upcoming milestone and would love to help where I can.

Woah... I just learned something new about the GUI! But I think that moving them to an arbitrary XY position is a "hacky" solution in comparison to showing a full 10-20 diagram and clicking the ones we want.

Just tested this on 5.0.5 and drag/drop in headplot doesn't seem reliable or well-put-together.

Very interesting.... thanks for sharing again!

markopetrovic-neurotech commented 3 years ago

Happy to help! Have a few developers have moved on from the project?

I agree it seems a bit hacky. I wonder if a drop down to select between different text files would be viable.

retiutut commented 3 years ago

Haha happy to help! Have a few developers have moved on from the project?

I agree it seems a bit hacky. I wonder if a drop down to select between different text files would be viable.

https://github.com/OpenBCI/OpenBCI_GUI/issues/966 . I don't really have time to go over how complicated 5.1.0 is, but I will be handling the bulk of the work. Let's keep this thread light, because the more I have to read later will only increase complexity.