search

OpenBCca / openbc-web

https://openbcca.github.io/openbc-web/
1 stars 2 forks source link

Pages and header v2 #25

Closed derekd03 closed 10 months ago

SamHuo213 commented 11 months ago

Let's try to get this in.

Please fix the failing check and we can merge it.

SamHuo213 commented 11 months ago

Please ensure you name branches

features/

SamHuo213 commented 11 months ago

I noticed the following issues 1) Multiple Project folder and nav component 2) Top Nav does not highlight based on page

Let's get this in and we can fix it later.

SamHuo213 commented 11 months ago

You have a lot of changes that I don't expect. Can you make sure to pull from main.

umsu2 commented 11 months ago

doesn't seem to be up to date to main. @SamHuo213 can you update the branch protection rule to ensure the branch must be up to date to main before allowing branches to be merged.

SamHuo213 commented 11 months ago

doesn't seem to be up to date to main. @SamHuo213 can you update the branch protection rule to ensure the branch must be up to date to main before allowing branches to be merged.

I am ok with adding this protection. I am not an admin, but we can quickly talk about it on Tuesday.

There is a dependency on this PR. It's based on a fork and Derek used rebase so it has some issues.

He might need your help to get this PR through. I am incline to get this in ASAP.