Add Axios and Github API tests

OpenBCca / openbc-web

https://openbcca.github.io/openbc-web/

1 stars 2 forks source link

Add Axios and Github API tests #27

Closed nam-m closed 11 months ago

nam-m commented 11 months ago

Added tests for

axiosConfig
getReposList()
getRepoInfo()

Pre-requisites:

mock-axios-adapter package is installed to mock axios
GITHUB_API_KEY is stored in src/.env.test.local, I changed this token retrieval method in github.client-service.ts to use process.env instead of nextConfig. Reference: https://nextjs.org/docs/pages/building-your-application/configuring/environment-variables

SamHuo213 commented 11 months ago

@nam-m , Great Job!

I really like the quality of UT here.

SamHuo213 commented 11 months ago

Your test are failing test btw.

nam-m commented 11 months ago

Resolved process.env issue in last commit Will try to not use axios-mock-adapter package and reopen this PR after

SamHuo213 commented 11 months ago

Thank you @nam-m , this is so close.

nam-m commented 11 months ago

Thanks @SamHuo213 @umsu2 a lot for your feedback!

I made changes based on your comments, and this is ready for review again. Also added a test to check undefined process.env.GITHUB_API_KEY in getAxiosInstance()