Closed jhourani closed 12 years ago
Issue believed resolved, to be re-evaluated by Nick Bargnesi.
We have what we need functionally, but there are several things worth noting.
Obey formatting conventions
Use the formatting conventions of whatever file you're currently
editing first, and whatever the conventions of the codebase are
second. In particular, your changes to Strings.java
include
tabs instead of spaces.
Make atomic commits
If you're addressing a specific issue, make that one commit with a relevant commit message. This means don't address an issue and remove interfaces in one commit.
Write good commit messages
This includes a short, one line summary followed by a detailed explanation if necessary (relevant blog post).
The help list needs to be updated to include describing the --no-orthology option when compiling a kam.