search

OpenBEL / openbel-framework

An open platform for capturing, integrating, storing, and sharing biological knowledge in and across organizations.
http://openbel.org
Apache License 2.0
22 stars 7 forks source link

invalid terms compile without error (and insufficient warning) #48

Open ncatlett opened 11 years ago

ncatlett commented 11 years ago

Terms using the functions pmod() or products() as outer functions compile without error or sufficient semantic warning. These BEL functions should be used within a proteinAbundance() or reaction() function, respectively.

Examples:

pmod(p(HGNC:PSEN1))

-this gets a warning that the expected signature for pmod is missing (mod type, aa, position) - nothing about the missing outer function

products(g(HGNC:IL12B),g(HGNC:CXCL10))

-this gets no warning

I suspect that reactants(), sub(), trunc() and fus() will behave similarly. These terms seem to be handled poorly by the API - see related issue for KAM Navigator.