OpenBEL / openbel-framework

An open platform for capturing, integrating, storing, and sharing biological knowledge in and across organizations.
http://openbel.org
Apache License 2.0
22 stars 7 forks source link

Incorrect signature for activity functions #67

Open abargnesi opened 8 years ago

abargnesi commented 8 years ago

Activity terms result in an abundance return type. For example kinaseActivity's signature is defined as:

kinaseActivity(F:abundance)abundance

It is then valid to embed an activity term in another abundance:

# signature: complexAbundance(F:abundance...)abundance
complex(kin(p(HGNC:JAK2)))

This should not be semantically valid. The activity functions should instead return their function as a result to catch this type of error.

See OpenBEL/language#8.