A shulker box crafted with the default ("") tag-match will not* match an instance created without any groups or tags
Environment and Version
EnderChest version: enderchest v0.1.4-beta1
rsync version: sync version 3.2.7 protocol version 31
Python version: Python 3.11.5
Operating System: Arch Linux x86_64 Kernel 6.5.9-arch2-1
Steps to Reproduce
After onboarding an instance with no tags or groups (freshly created via PrismLauncher with no group assignment), going through the enderchest craft shulkerbox wizard:
Filters match the instance: Tagless
==> Do you wish to continue?
==> [Y/n] y
==> Tags?
==> e.g.vanilla-plus, multiplayer, modded, dev, april-fools
==> (or multiple using comma-separated lists or wildcards)
==> Note: tag-matching is not case-sensitive.
==> [*]
Filters do not match any known instance.
==> Do you wish to continue?
==> [y/N] n
==> Tags?
==> e.g.vanilla-plus, multiplayer, modded, dev, april-fools
==> (or multiple using comma-separated lists or wildcards)
==> Note: tag-matching is not case-sensitive.
==> [*] *
Filters do not match any known instance.
==> Do you wish to continue?
==> [y/N]
where the entry in the enderchest.cfg looks like:
[Tagless]
root = instances/Tagless/.minecraft
minecraft-version = 1.20.1
modloader = Some Loader
groups =
tags =
Furthermore, running enderchest inventory minecraft Tagless returns the message:
The instance Tagless (instances/Tagless/.minecraft) does not link to any shulker boxes in this chest
even though I have "global" shulker boxes that should match
Workaround
Add a "placeholder" tag to the instance manually, in enderchest.cfg
Severity
Gamebreaking. In the case of a "global" shulker box, this could go completely missed until there were already a ton of conflicts.
Summary
A shulker box crafted with the default ("") tag-match will not* match an instance created without any groups or tags
Environment and Version
Steps to Reproduce
After onboarding an instance with no tags or groups (freshly created via PrismLauncher with no group assignment), going through the
enderchest craft shulkerboxwizard:where the entry in the
enderchest.cfglooks like:Furthermore, running
enderchest inventory minecraft Taglessreturns the message:even though I have "global" shulker boxes that should match
Workaround
Add a "placeholder" tag to the instance manually, in
enderchest.cfgSeverity
Gamebreaking. In the case of a "global" shulker box, this could go completely missed until there were already a ton of conflicts.
Desired Outcome
Fix
Urgency
By next minor release (https://github.com/OpenBagTwo/EnderChest/milestone/6)
Notes
This issue is arising because there's no check here for
instance.tagsbeing empty:https://github.com/OpenBagTwo/EnderChest/blob/6829ffae78386b939188ef814bd77465de0ebfe9/enderchest/shulker_box.py#L215-L222