OpenBagTwo / EnderChest

syncing and linking for all your Minecraft instances
https://openbagtwo.github.io/EnderChest/
GNU General Public License v3.0
3 stars 2 forks source link

place-after-open is being set to True for legacy chests #91

Closed OpenBagTwo closed 1 year ago

OpenBagTwo commented 1 year ago

Summary

An EnderChest loaded by EnderChest v0.1.3-beta that had been generated prior is getting its value for place-after-open set to True instead of False as it's supposed to

Environment and Version

Steps to Reproduce

  1. Take an existing EnderChest last edited prior to v0.1.3-beta (or just delete the place-after-open line in the config)
  2. Run enderchest open
  3. Observe how even though you get the expected message:
    This EnderChest does not have a value set for place-after-open.
    It is being set to False for now. To enable this functionality,
    edit the value in /main/minecraft/EnderChest/enderchest.cfg

    after the sync completes you get a bunch of linking messages

  4. And when you open enderchest.cfg for editing you find:
    ; enderchest.cfg
    [properties]
    ...
    place-after-open = True

Workaround

Open the file and set the value to False. Do this before running the first open.

Severity

Potentially gamebreaking if you rely on stale or broken symlinks (for whatever reason)

Desired Outcome

Fix

Urgency

Emergency (requires fixing and pushing out a new beta)

Notes

I literally cannot figure out why this is happening--I even have tests saying it shouldn't!