OpenBagTwo / FoxNap

A survival-, multiplayer- and copyright-friendly mod for adding custom music discs to your world
GNU General Public License v3.0
1 stars 1 forks source link

Resourcepack Generator #10

Closed OpenBagTwo closed 1 year ago

OpenBagTwo commented 1 year ago

Upon merge, this PR will resolve #1 by adding a simple-to-use resourcepack generator to this repo.

Done So Far

To Do

OpenBagTwo commented 1 year ago

Got builds going for Windows, macOS and Linux, but at some point it looks like I broke versioneer.

OpenBagTwo commented 1 year ago

Fixed version-freezing. Yay!

OpenBagTwo commented 1 year ago

I'm going to de-scope Linux arm64 builds for now (pending https://github.com/actions/runner-images/issues/5631) and instead change the action item to providing instructions for manual building on arm64 devices.

Regarding automatic testing on all platforms: the explicit risk to call out isn't that the unit tests fail (though that's a concern) but that the launcher won't work.

Double-click-to-execute is not something I can automatically test with GitHub's CI runners, but I can test calling the executables from the command line and running against either a test folder or against the oggs already in the mod source (that won't test that the decoders are working, but that's also the least likely thing to break) and explicitly verify:

OpenBagTwo commented 1 year ago

Oh, also noting that the macOS build appears to be either a universal binary or at least runs well through Rosetta 2--had no issues running on either an M1 Macbook Air or a 2012 (Intel) Macbook Pro

OpenBagTwo commented 1 year ago

Well that's been a journey, but I've actually got everything working how I want it for now.

Before merging, I just want to call out some:

Tech Debt