search

OpenBagTwo / FoxNap

A survival-, multiplayer- and copyright-friendly mod for adding custom music discs to your world
GNU General Public License v3.0
1 stars 1 forks source link

Test compatibility with 1.19.1 #18

Closed OpenBagTwo closed 1 year ago

OpenBagTwo commented 1 year ago

I jumped straight from 1.19.0 to 1.19.2 when developing this mod so never tested what changes would be required for 1.19.1. As I'm now looking at targeting 1.19.3, it's awkward to be skipping over a single patch-version.

It seems likely that either the 1.19.0 or 1.19.2 versions will be compatible, but if not, I'd rather not support 1.19.1 than create a dedicated build branch.

OpenBagTwo commented 1 year ago

The 1.19.2 build specifies that it requires 1.19.1 or greater:

https://github.com/OpenBagTwo/FoxNap/blob/bca0cb21cc605178998c8598b45c6038194ad651/src/main/resources/fabric.mod.json#L26

(I'm not sure whether I should be specifying a max version here? In my experience, I've had more problems with mods setting the max version when it turned out it was compatible than mods breaking in non-obvious ways when a new release comes out)

I spun up a 1.19.1 instance, and the 1.19.2 build ran fine.

So I just need to make a mental note of that fact.