search

OpenBagTwo / FoxNap

A survival-, multiplayer- and copyright-friendly mod for adding custom music discs to your world
GNU General Public License v3.0
1 stars 1 forks source link

build_mod workflow jars show version as 0.0.0-0 #27

Closed OpenBagTwo closed 1 year ago

OpenBagTwo commented 1 year ago

Unclear if these are just filenames or the actual versions that will show up in-game. I'm especially concerned that actual release builds still won't pick up the version.

This seems like the Java equivalent of versioneer's 0+unknown issue, but I don't have this problem building locally, and the process should be identical on the workers.

It's not strictly necessary that this be resolved before the release--I don't even have a release workflow (#26)--as I can always use a local build as the release jar, but if jgitver isn't working for me, I should see what other options are out there (I know I have mods I've used where the version shows as "1.19+build.6")

OpenBagTwo commented 1 year ago

This is also an issue with versioneer: builds of FoxNapRPG showing as, for example,

foxnap-rpg-0+untagged.1.gcf466df

This is a major problem because while I do have access to Mac and Windows (through a VM), doing manual builds would be a pain in the toucans.

OpenBagTwo commented 1 year ago

Okay, I suddenly remember this sort of thing happening in Jenkins once the number of commits since the last release got super high. I'm hopeful that b21162a might let me work around this.

OpenBagTwo commented 1 year ago

Resolved by #28

OpenBagTwo commented 1 year ago

Just noticed the build is missing the "1.19.2" suffix... Not gonna worry about it for now.