OpenBagTwo / FoxNap

A survival-, multiplayer- and copyright-friendly mod for adding custom music discs to your world
GNU General Public License v3.0
2 stars 1 forks source link

Client-disabled discs should have placeholder sound files and textures #29

Closed OpenBagTwo closed 1 year ago

OpenBagTwo commented 1 year ago

If a player is playing in a world where the number of discs available is greater than the number n_discs they have enabled in their config--a scenario that can happen:

then those discs should render with:

and their minecraft logs shouldn't be filled with scary warnings about missing texture and sound files.

If n_discs > 7 but the player has not loaded a custom resource pack, the player should still see those messages and should also have to deal with missing missing textures, etc. in-game, as a reminder to either:

Original OP If a server (or single-player) sets the `n_records` higher than the number of build-in records / number defined in a player's resource pack, the records will show up with missing textures, language entries and sound files. But it should be possible to assign each item a default texture (maybe a semi-transparent "clear vinyl"?) and set the item description to "Music Disc - 4'33" (though [maybe not that specifically](https://www.youredm.com/2015/11/28/soundcloud-finally-goes-too-far-removes-silent-track-for-copyright-infringement-2/)). Not for the initial release
OpenBagTwo commented 1 year ago

See:

Update: lolno--these were for generating static assets in order to keep one's codebase DRY and svelte. The relevant fabric tutorial--to the extent that one exists--is this, but by far the best resource I found was combing through the codebase of BetterEnd

OpenBagTwo commented 1 year ago

I'm questioning the original intent here--isn't it useful to differentiate between "this track is disabled" and "you forgot to set the texture / track"? If so, then the behavior should be that:

(fwiw, that's what I have implemented right now at f01ede7)

On the other hand, the overriding intent is that this is a social mod where different players can have different discs and different numbers of discs, and that the intent described here allows servers to turn up the n_discs to a number greater than all players will always have. In that scenario, the ideal behavior would be for players with fewer discs to receive placeholders from The Maestro that can later become real discs if they load an appropriate resource pack.

But then again, #35 already solved for that use-case, as players can simply set different n_discs in their config... as they should be doing anyway by plopping in the config file created by the Resource Pack Generator.

All right. I'm sold. Placeholders for discs > n_discs regardless of whether that's above or below 7.