OpenBagTwo / FoxNap

A survival-, multiplayer- and copyright-friendly mod for adding custom music discs to your world
GNU General Public License v3.0
1 stars 1 forks source link

Default track duration is too long #31

Closed OpenBagTwo closed 1 year ago

OpenBagTwo commented 1 year ago

See #30:

Currently all music discs have a track length of five minutes. As far as I know, as of 1.19.,3, the only effect this has on the vanilla game is that it dictates how long Allays will dance for.

However, the SBM-Jukebox mod has evidently implemented the Bedrock behavior of locking music discs while playing (See: https://github.com/StrikerRockers-Mods/SBM-Jukebox-fabric/issues/2). Thus, this value may actually matter for some players (like myself) when making redstone-powered playlists.

30 outlines the full solution--set the default values to match the tracks, and make everything configurable--but given that most of the tracks are sub-2m, setting the play time to 5m is going to be massively inconvenient for anyone using the newest version of the SBM-Jukebox mod.

The band-aid solution is to set the default duration to 60 seconds, which will limit how long your Allays dance, but at least it'll allow players to manage the actual playtimes using hopper clocks like they would have previously.