Resource Pack Sometimes Fails To Overwrite Music

[OpenBagTwo]

Summary

Applying a FoxNapRPG-generated resource pack in a world with the FoxNap mod will sometimes fail to actually override the music the disc plays (the built-in song will be the one that plays). The item texture and name will be correct.

Relevant Versions

• Pack generated using FoxNapRPG v0.1.0-rc2+5.g7df4e31
• Playing on Minecraft 1.19.2, using Fabric Loader 0.14.11
  • Fox Nap version: v0.1.0-rc2-0.1.19.2
  • Java is version 17.0.4.1, using 64 (amd64) architecture, from Flathub (PrismLauncher)
  • Using Fabric API v0.63.0+1.19.2
  • Using SBM-Jukebox v1.0.7
  • Other mods include Sodium (0.4.4), Lithium (0.10.2), Phosphor (0.8.1), LazyDFU (0.1.3), BCLib (2.1.4) and BetterEnd (2.1.2)

Steps to Reproduce

1. Load Resource Pack
2. Apply Resource Pack
3. Load World

This has also happened when applying the resource pack after world load or making no changes and reloading using F3-T. I have not noticed whether this only happens when using tracks that are overriding the built-in songs or whether this will happen with tracks numbered 8 or higher.

Workaround

Sometimes F3-T fixes the issue, sometimes it causes it when the track was working previously.

Severity

Major. Customizing music is the primary selling point of the mod.

Desired Outcome

Fix

Urgency

Before v0.1.0 release

[OpenBagTwo]

This is actually happening even without reloading resources--I play one disc, it's fine. Play a second, it's fine. Play a third, it's wrong, then go back and play the first, and it's also wrong.

Nothing in the logs indicating a problem.

[OpenBagTwo]

Oh you nitwit.

 replace: true/false. Used only in resource packs. True if the sounds listed in sounds should replace the sounds listed in the default sounds.json for this sound event. False if the sounds listed should be added to the list of default sounds. Optional. If undefined, defaults to "false".

:facepalm:

At least this is going to be a ridiculously simple fix.