Closed uczpre closed 2 months ago
Hi @uczpre! I'm glad to hear you're trying my mod, and I'm delighted that you're finding the resource pack generator easy enough to use without the UI.
I'd have to see your Minecraft logs to be sure, but I suspect the issue is that you have 69 tracks, which exceeds the default maximum of 64.
Try editing your YAML to add the following line top of your config (like, right below n_discs
):
max_discs: 69
and see if the discs show up then.
That....... absolutely fixed it ! (up to the 64th track) while all them shows up in the game , the 65th track wont do anything when interacted with a jukebox :( also you need to let people know of the max_discs behaviour lol , dont forget to update the generator to make it include max_discs in the .yaml config file. anyways , is this "up to 64" behaviour fixable ? or is it a limit set my minecraft or smthing ?
please do let me know ! ;D
didnt mean to press that :D
Hmm... can you upload your Minecraft log? Nothing should be hard-coded to 64, but it's always possible I have a bug somewhere.
Arch btw ;D Ive played the tracks from the .zip resouce pack , it works , not missing at all. Seems like a an isue with the code to me :(
Aha! I've found the issue:
That is: the additional music discs are not being tagged as music discs.
A workaround for now would be to create a datapack that you can use in your world that just extends this list as far as you want it to go, but that's obviously far from ideal.
I'm confirming this as a bug and will prioritize fixing it for the next release (along with documentation updates for how to up the maximum number of discs which, you should be aware, breaks multiplayer unless all players have the same max_discs
value set).
I suppose it'll be best if you update the docs and description of the mod , remove or edit this line of text "Enables each player to add as many (or as few) discs as they want, containing their own music" as to let end-users know that theres a bug with this intended feature(64 is max rn) and a fix is being worked on. or you could just quickly fix and update the generator ?
The title bug is fixed by e648015ac9492ec06ae2389541ea00c7e1981e22 so it'll be part of the release I generate for 1.20.5+ at the very least. I should also be able to backport the fix to 1.20.4 (I don't believe the issue is present in 1.20.1 or below).
I won't close this issue, however, until I update the resourcepack generator to set max_discs
when the number of discs generated is greater than 64.
i tested it in 1.20.1....... :( i mean , you can see it in my log lol pls fix for 1.20.1 , or i would be very sad :(
Yes, I will absolutely be porting this fix back to 1.20.1
This has now been backported to all prior affected versions of the game (1.19.4-1.20.4)
as stated by the instructions , i loaded the foxnap.zip resource pack and placed foxnap.yaml to my config folder generated by the generator executable on the directory it was on. How ever , only seven of my 69 custom music disc show up. even after multiple restarts and reinstalls. Perhaps somthing wrong with what was generated ? im using the newest version for 1.20.1 (both mod and generator tool)
https://mega.nz/file/EZ8VVYCb#g041ksGVDV1Xcb9ovM3LWv5VkwtPLlf8kVzP3qmMl_8
Please look into it !
Beggingly. Ukzpre Mustafin.
somthing i also would like to tell you : The generator doesnt need a GUI , i dont want to press a start button after launching the executable. there are other things that i believe is more critical , like say having a house with a jukebox spawn in villages ! (Choice theorem's overhauled village while overhauls the village generation , has a tendency to provide mods to allow such custom structures by other mods to generate with/inside the village).