OpenBagTwo / FoxNap

A survival-, multiplayer- and copyright-friendly mod for adding custom music discs to your world
GNU General Public License v3.0
1 stars 1 forks source link

Jukebox songs enabled on server but not client show track names instead of placeholder text #56

Open OpenBagTwo opened 2 weeks ago

OpenBagTwo commented 2 weeks ago

Summary

If a client connects to a server where their value for n_discs in foxnap.yaml is lower than the value in the server's config file, then when a "placeholder" disc obtained in that world is played in that world, the name of the track—or an untranslated reference, e.g. item.foxnap.track_35.desc—will be displayed instead of the expected placeholder text ("Joe Box - 4.33").

Note that no sound plays (good!) and the disc still renders correctly, with the correct tooltip (good!)

Relevant Versions

FoxNap v0.2 for Minecraft 1.21

Steps to Reproduce

  1. Create a server with the default foxnap.yaml
  2. Create an instance and set the value of n_discs in foxnap.yaml to, say, 4
  3. Join the server from the instance
  4. Obtain FoxNap Disc 6 (creative mode, or from a Conductor Villager)
  5. Play music disc

Workaround

Create a resource pack that manually sets the item.foxnap.track_<n>.desc values to the expected placeholder

Severity

Purely cosmetic

Desired Outcome

Fix, if possible (see note)

Urgency

None (tentatively scoped for the next release)

Notes

I'm not sure how possible this is, given that this is set via the JukeboxSong Registry (and thus controlled by the server-side datapack values). It's possible that there's some way to brute-force the translation lookup involving a Mixin.