OpenBagTwo / FoxNap

A survival-, multiplayer- and copyright-friendly mod for adding custom music discs to your world
GNU General Public License v3.0
1 stars 1 forks source link

Fox Nap Datapack Does Not Work in Vanilla #58

Closed OpenBagTwo closed 2 weeks ago

OpenBagTwo commented 2 weeks ago

Summary

Even though everything should be data-driven now, trying to load a Fox Nap-generated datapack in vanilla Minecraft (#55) fails (gives the message on screen "Errors in currently selected datapacks prevented the world from loading"), with logs showing:

java.lang.IllegalStateException: Failed to parse foxnap:jukebox_song/track_8.json from pack file/FoxNapDP.zip

etc.

Relevant Versions

FoxNap v0.2-rc1 for Minecraft 1.21

Steps to Reproduce

  1. Use the Fox Nap Resource Pack Generator to generate a resource and datapack for some custom music
  2. Load that datapack into a new world (optionally enable the resource pack)
  3. Attempt to load the world

Workaround

Install the Fox Nap mod and set n_discs to zero and disable the Maestro :upside_down_face:

Severity

Prevents resolving #55

Desired Outcome

Fix

Urgency

Immediate—this was scoped for the v0.2.0 release

OpenBagTwo commented 2 weeks ago

I think I see what I did wrong:

https://github.com/OpenBagTwo/FoxNap/blob/6922e10eb1892e374c42ea7e5288f71b1fdcfb3d/foxnap_rpg/data_generator.py#L76

is supposed to be:

"sound_event": {"sound_id": "foxnap:{song_name}"}