search

OpenBagTwo / FoxNap

A survival-, multiplayer- and copyright-friendly mod for adding custom music discs to your world
GNU General Public License v3.0
1 stars 1 forks source link

Validate that servers and clients can have different music #8

Closed OpenBagTwo closed 1 year ago

OpenBagTwo commented 1 year ago

That's the "killer app" of this whole thing

OpenBagTwo commented 1 year ago

Dang it. 2022-12-08_22 56 36

Looks like the way things are now the server just won't let a client join that has fewer discs specified in the config than the server. Going the other way appears to allow the client to join, but the behavior is glitchy and inconsistent (shows up in creative inventory, but popping it into a jukebox causes the disc to become another disc item registered with a random other sound?)

The good news is that the "different music" part works fine, and if the client simply doesn't have the textures and music files registered, they see a missing texture and hear silence when the disc plays (so #29 is looking good).

I'm converting this issue to a bug.

OpenBagTwo commented 1 year ago

Reopening to note that this needs to be tested on 1.19.0 and 1.19.3 as well

OpenBagTwo commented 1 year ago

1.19.0 looking good on rc2

Useful command for quickly testing conductor max-level trades (and how they'll appear for the client):

summon villager ~ ~ ~ {VillagerData:{profession:"foxnap:conductor",level:5,type:swamp}}
OpenBagTwo commented 1 year ago

Looking good on both 1.19.1 (with the 1.19.2 version of the mod) and (to my amazement and relief) 1.19.3.