linting - Githubissues

OpenBagTwo / gsb

A tool for managing incremental backups of your save states using Git!

https://openbagtwo.github.io/gsb/

GNU General Public License v3.0

0 stars 0 forks source link

linting #18

Closed OpenBagTwo closed 1 year ago

OpenBagTwo commented 1 year ago

Summary

Addresses this travesty

pylint-score-of-5.99

List of Changes

Explicitly enumerates the pygit2 members that pylint is unable to resolve (h/t @shuttle1987 for this)
puts in an explicit ignore to work around https://github.com/pylint-dev/pylint/issues/7891
addresses a couple of actual and legitimate findings

Tech Debt and Other Concerns

Validation Performed

[x] Unit tests pass
[x] Running pylint myself brought my score well above 9.0

PR Type

[ ] This PR introduces a breaking change (will require a bump in the minor version)
[ ] The changes in this PR are high urgency and necessitate a hotfix or patch release (will require rebasing off of release)
[ ] This is a release (staging) PR (maintainer use only)

Checklist:

[x] I have read the contributor's guide
[x] I have run mkdocs serve locally and ensured that all API docs and changes I have made to the static pages are rendering correctly, with all links working
[x] All tech debt concerns have been resolved, documented as issues, or otherwise accepted
[x] I agree to license my contribution to this project under the GNU Public License v3

shuttle1987 commented 1 year ago

Glad to see you were able to improve the accuracy of pylint!