Rewind fails (to tag) - Githubissues

Summary

Performing `gsb rewind' produces the error

<commit hash>: tag already exists

and the restored version doesn't show up at the top of gsb history

Environment and Version

gsb version: gsb, version 0.0.2
git version: git version 2.42.0
Python version: Python 3.11.6
Operating System: SteamOS 3.4.11

Steps to Reproduce

Perform a gsb rewind when you have unsaved changes

Workaround

I believe the issue is just tagging. If I do a git diff of the HEAD and the backup I was attempting to restore, I get that they match. Furthermore, git log shows the most recent commit as having the expected "restored" message.

I also think this could be avoided by doing a gsb backup --tag before doing the restore (so that there's nothing to back up before rewinding).

Severity

Annoying. Especially since the restored backups are not annotated as such. Also the error message seems wrong, since the duplicate tag name isn't shown, just a commit hash.

Desired Outcome

Fix

Urgency

By next minor release

Notes

Two issues:

The "existing tag name" message should give the tag name
Since gsb versioning uses calver, the issue is that the two backups are getting the same tag, as they're happening in the same second. Suggestion is that restored tags should be given distinct names (tack a ".restore" on the end or something).

Separately there should probably be an option to delete a backup that's been restored (and that option should perhaps be the default).

OpenBagTwo / gsb

Rewind fails (to tag) #42