OpenBankingToolkit / openbanking-aspsp

ForgeRock OpenBanking ASPSP
Apache License 2.0
5 stars 4 forks source link

Account data returned from 3.1 `/accounts` endpoint contains incorrect scheme name value #215

Closed BohoCode closed 4 years ago

BohoCode commented 4 years ago

Customer Issue: 48067

The response from the /open-banking/v3.1/aisp/accounts endpoint returns the following sample data;

"Data": {
           "Account": [
             {
               "AccountId": "0cdaa0d0-0875-492d-be47-df617a1d42fe",
               "Currency": "GBP",
               "AccountType": "Personal",
               "AccountSubType": "CreditCard",
               "Account": [
                 {
                   "SchemeName": "PAN",
                   "Identification": "525302******7553",
                   "Name": "Mr Zak Matusak"
                 }
               ]
             },
             {
               "AccountId": "1957ee43-faae-4601-bb73-140259039e38",
               "Currency": "GBP",
               "AccountType": "Personal",
               "AccountSubType": "CurrentAccount",
               "Nickname": "NickZero",
               "Account": [
                 {
                   "SchemeName": "SortCodeAccountNumber",
                   "Identification": "80064711123468",
                   "Name": "Mr Zak Matusak"
                 }
               ]
             } ...

As you will notice, "SchemeName” is appearing as SortCodeAccountNumber. This should appear as UK.OBIE.SortCodeAccountNumber.

BohoCode commented 4 years ago

Jorge's update in the customer issue; docs: https://openbanking.atlassian.net/wiki/spaces/DZ/pages/937623627/Accounts+v3.1

Source to check:

matt-wills commented 4 years ago

PRs merged and change tested.