874: Allow multiple VRP payments for a consent

OpenBankingToolkit / openbanking-aspsp

ForgeRock OpenBanking ASPSP

Apache License 2.0

6 stars 4 forks source link

874: Allow multiple VRP payments for a consent #501

Closed dbadham-fr closed 2 years ago

dbadham-fr commented 2 years ago

Bug fix to allow multiple VRP payments to be made for a single consent, the fix is being made to v3.1.8 and v3.1.9 implementations

Using Mongo to generate the id for the FRDomesticVrpPaymentSubmission (rather than using the consentId), and returning this value as domesticVRPId
v3.1.9 - add missing x-idempotency-key header to the API calls in order to implement idempotency
v3.1.8 - no idempotency support as the header is not in the OBIE spec, for consistency with v3.1.9 logic we generate a unique idempotencyKey value internally for this version

Issue: https://github.com/ForgeCloud/ob-deploy/issues/874

jsanhc commented 2 years ago

Confirmed: Only VRPs payment support more than one submit payment under an authorised consent. Consent [1] ---> [*] vrps

jsanhc commented 2 years ago

Pending to discuss.

This fix will work for version 3.1.9 because the x-idempotency-key header has been defined as required in open api version 3.1.9 but isn't defined for open api version 3.1.8, in consequence we can't force the tpp to use the x-idempotency-key header when is consuming the vrps api version 3.1.8.

One solution could be generate internally the x-idempotency-key for those vrps api versions that doesn't defined that header in the spec to implement the same solution and keep the same behaviour through all VRPs api versions.

dbadham-fr commented 2 years ago

That's correct about 3.1.8, what you suggest makes sense and will make the controller logic consistent.