OpenBazaar / OpenBazaar-Installer

Process for building the OpenBazaar 1.0 executables on OSX, Linux and Windows
MIT License
123 stars 62 forks source link

Windows: User environment variable PATH is overwritten #2

Open AronVanAmmers opened 9 years ago

AronVanAmmers commented 9 years ago

After running the installer (a build downloaded on 2015-10-22), I noticed I could no longer execute npm packages which were installed globally.

When debugging that, I noticed that my Path variable (System > Advanced System Settings > tab Advanced> Environment Variables > User variables for [Username]) was now as below:

%PATH%;C:\Users\Aron\AppData\Local\OpenBazaar\python27;C:\Users\Aron\AppData\Local\OpenBazaar\python27\scripts;%AppData%\npm\node_modules

Before installing it contained other paths, including the global npm path.

I believe this line overwrites that variable instead of amending it:

[Environment]::SetEnvironmentVariable("PATH", "%PATH%;$INSTDIR\python27;$INSTDIR\python27\Scripts", "User")
hoffmabc commented 9 years ago

Interesting. I will take a look and see what's going on with that. I don't believe that line will be necessary in the updated installer build script as well.