search

OpenBazaar / OpenBazaar-Installer

Process for building the OpenBazaar 1.0 executables on OSX, Linux and Windows
MIT License
123 stars 62 forks source link

make_openbazaar.sh typo fix for bash and fish shells, remove brew call and added wine as required dep in README.md #7

Closed M0Rf30 closed 8 years ago

M0Rf30 commented 8 years ago

fish says Failed to execute process './make_openbazaar.sh'. Reason:

exec: Exec format error

The file './make_openbazaar.sh' is marked as an executable but could not be run by the operating system.

bash says; make_openbazaar.sh: riga 1: #!/bin/sh: File o directory non esistente

M0Rf30 commented 8 years ago

Refactor make_openbazaar.sh in order to be distro agnostic

M0Rf30 commented 8 years ago

Perhaps there will be some errors for OSX building process, but I can't test

M0Rf30 commented 8 years ago

Instead of accept my pull request and fix macos errors compilation after, you think could be better read the suggestions and make my fork unusable for merge?

hoffmabc commented 8 years ago

Sorry if I am misunderstanding you @M0Rf30 ...I don't understand the question. I am going to read through and try to help resolve.

hoffmabc commented 8 years ago

OK I think I understand that you are agitated because I broke your PR with some later commits. I didn't realize you even had this PR submitted since it was a few days ago and I wasn't around. Apologies. I will try and pull down your branch and figure out how to clean it up for you.

hoffmabc commented 8 years ago

OK I resolved the conflicts and merged. Sorry for being confusing.

M0Rf30 commented 8 years ago

You are a sir, I'm happy to contribute to this futuristic project. My tones were not dictated by anger or ambition, but truly spirit of partecipation.

M0Rf30 commented 8 years ago

Could you take a look at this? https://aur.archlinux.org/packages/?O=0&K=openbazaar

This is my work of packaging for ArchLinux AUR. All the variants are fully working since your first works Archlinux has a different method of packaging, more distro-agnostic respect to the most popular distros.

yagoulas commented 8 years ago

Hello, there is something really weird with this pull request. Can you clarify that all these commits were meant to be submitted?

M0Rf30 commented 8 years ago

I'm cleaning some errors regarding the packaging and extra data not needed by a well-done package. I've just collaborated to rewrite the make_openbazaar script. Now I'm just refining my work. The commits speak clearly

yagoulas commented 8 years ago

Can you recheck the list of the commits that were merged? The list is huge and you have several changes that are related to windows and you don't mention them anywhere. The list of commits: https://github.com/OpenBazaar/OpenBazaar-Installer/pull/7/commits

M0Rf30 commented 8 years ago

for ob.nsi: I've basically cleaned nodejs refs not required setted PYTHON global variables in win environment setted python.exe in win firewall in order to obtain first runnable openbazaar session removed an unneeded variable in nsis files splitted win64 and win32 packages used noupnp branch for server, cause of miniupnpc not compiled yet on win OS used upx compression properly used correct python executable in systray changed pyinstaller to git release cause of "match_ssl_hostname" error

yagoulas commented 8 years ago

Can you join slack to discuss this?

M0Rf30 commented 8 years ago

How. I've never used slack. Invitation needed?

hoffmabc commented 8 years ago

@M0Rf30 go here for an invite. https://openbazaar-slackin-drwasho.herokuapp.com/

M0Rf30 commented 8 years ago

I'm on slack