search

OpenBazaar / OpenBazaar-Server

(Deprecated) OpenBazaar 1.0 Server daemon for communication with OpenBazaar-Client
MIT License
608 stars 173 forks source link

Add Title to Search API #122

Open jjeffryes opened 8 years ago

jjeffryes commented 8 years ago

We should add title and maybe description to the search API, so it returns more accurate results.

cpacia commented 8 years ago

What do you mean by title and description?

morebrownies commented 8 years ago

Basically the search needs to be more fuzzy and match on keywords and/or title instead of only keywords.

When I searched "Rolex" I expected to see Brian's watches come up (because I saw them in Discover), but they didn't show up because he never added keywords to them, which makes it more difficult to filter down to what you're looking for.

cpacia commented 8 years ago

That's going to be more difficult. If we had a way to pull keywords out of the title we could stick them in the dht but I don't know how to do that.

This is partly why I'd like to have the option to switch search api to something that can handle it better.

jjeffryes commented 8 years ago

It would be pretty easy to pull words out of the title in the client, and send them to the API either as additional keywords, or as some other key, whenever an item is saved.

If they were keywords, they would appear in the keyword list when the user was editing their items, which could be confusing, but might also be good since it would show them what was being used for searching. And if they deleted the keywords from the title, the client would just reinsert them when the item was saved.

If they were a separate piece of data, then that could be cleaner from the client side, but I don't know if that would make things harder on the server side.

cpacia commented 8 years ago

Well the problem is doing it intelligently. So it isn't storing "the" and "a" for all of them. Then you might have an issue with someone searching for "honey" and getting back a "honey colored 4-drawer chest".

Also have to consider title length as well.

drwasho commented 8 years ago

I think with the advent of channels, adding the entire title of the listing in the DHT is unnecessary.