search

OpenBazaar / multiwallet

API based multi-cryptocurrency wallet
MIT License
75 stars 41 forks source link

Prevent AddWatchedAddress from adding a script that represents an exi… #116

Closed rodkeys closed 4 years ago

rodkeys commented 4 years ago

These changes ensure that AddWatchedAddress should never add a script which already represents a key from the appropriate wallet.

Also added tests to verify that watch scripts are added properly. Finishes issue #107.

hoffmabc commented 4 years ago

We're migrating to AddWatchedAddresses from AddWatchedAddress so this will probably need to be refactored.

hoffmabc commented 4 years ago

See: https://github.com/OpenBazaar/multiwallet/pull/108

rodkeys commented 4 years ago

We're migrating to AddWatchedAddresses from AddWatchedAddress so this will probably need to be refactored.

Alright thanks for the heads up, I'll wait for that PR to get merged and then refactor

placer14 commented 4 years ago

@rodkeys The dependant PR is merged. LMK after you've updated and this is ready to review.