OpenBazaar / multiwallet

API based multi-cryptocurrency wallet
MIT License
75 stars 41 forks source link

Fix zcash balance calculation #93

Closed cpacia closed 5 years ago

cpacia commented 5 years ago

This commit fixes a bug calculating zcash balances when spending confirmed change. There were two ways to fix it, either build a zcash-specifc calculation function or trim the zcash transaction so that the util.CalcBalance function can be used. We opt for the later so as to stick with code that we know has been working well and also because parts of the transaction that are being trimmed are not relevant to the balance calculation.

closes #91

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 450


Totals Coverage Status
Change from base Build 436: 0.2%
Covered Lines: 2769
Relevant Lines: 5078

💛 - Coveralls