search

OpenBazaar / openbazaar-desktop

OpenBazaar 2.0 Desktop Client (talks to openbazaar-go server daemon)
MIT License
647 stars 186 forks source link

Refactor mod loading #1859

Closed jjeffryes closed 4 years ago

jjeffryes commented 4 years ago

This cleans up and improves the handling of loading mods.

It also fixes an issue where sometimes the empty placeholder was being shown instead of one of the messages that explained no moderators were being shown. Now the loading message will be shown while loading, and one of the other messages will be shown if no valid moderators were loaded.

Closes #1851

jjeffryes commented 4 years ago

Closed while I fix a bug.

rmisio commented 4 years ago

This one happens on this branch:

https://github.com/OpenBazaar/openbazaar-desktop/issues/1862

Not sure if it was introduced by this branch since I haven't tested it on master. If it does happen on master we could punt on it and prioritize later.

jjeffryes commented 4 years ago

This is closed in favor of #1864, since non-critical updates should be happening on eth-master instead.