search

OpenBazaar / openbazaar-desktop

OpenBazaar 2.0 Desktop Client (talks to openbazaar-go server daemon)
MIT License
647 stars 186 forks source link

Handle invalid mods better #1861

Closed jjeffryes closed 4 years ago

jjeffryes commented 4 years ago

This changes the behavior in settings/store so invalid moderators (moderators with models that don't validate) are still shown.

The card will validate the model and show an error if it is invalid, with the specific errors listed in the card.

Sometimes isValid returned true when I manually put in invalid data for the models, which is weird. I wasn't able to figure out the cause, so there's an extra layer of checking in the card template that protects the fee data, and shows the existing currency mismatch message instead of the currency information if the currency code for the fixedFee is unknown or invalid.

jjeffryes commented 4 years ago

This is closed in favor of #1864, since non-critical updates should be happening on eth-master instead.